[5.1] IDE: avoid merging extensions with @available attributes when synthesizing extensions #27047
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…izing extensions rdar://54804607
|
@swift-ci please test |
akyrtzi
approved these changes
Sep 5, 2019
|
@swift-ci please nominate |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Explanation: When generating documentation using sourcekitd, we sometimes merge extensions with the identical constraint. This could lead to some information loss if two extensions of different availability attributes are merged. This simple fix checks if an extension has an explicit available attribute and avoids merge it with other extensions if so.
Scope: Only for document generation request of sourcekitd
Issue: rdar://54804607
Risk: Very Low since the changes are of no direct impacts on end users
Testing: local testing; unit testing; CI testing
Reviewed by: @jrose-apple