[SILOptimizer] Added MandatoryCombiner. #27049
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
@swift-ci please ASAN test |
|
Build failed |
nate-chandler
force-pushed
the
add-mandatory-combiner-frame
branch
from
e816d87 to
fcba7e5
Compare
|
@swift-ci please test |
1 similar comment
|
@swift-ci please test |
|
@swift-ci please ASAN test |
1 similar comment
|
@swift-ci please ASAN test |
gottesmm
reviewed
Sep 6, 2019
nate-chandler
force-pushed
the
add-mandatory-combiner-frame
branch
3 times, most recently
from
82c57de to
0d371c1
Compare
|
@swift-ci please test |
gottesmm
approved these changes
Sep 6, 2019
nate-chandler
force-pushed
the
add-mandatory-combiner-frame
branch
from
0d371c1 to
0ad2183
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
nate-chandler
force-pushed
the
add-mandatory-combiner-frame
branch
from
0ad2183 to
df105d8
Compare
|
@swift-ci please test |
Minimal commit to get the mandatory combiner rolling. The intent of the mandatory combiner is to do basic transformations after the diagnostics passes have run at the beginning of both the Onone and the performance pipelines. For now, it simply visits reachable instructions and does no work. In a subsequent commit, apply instructions will be processed and replaced if they are calls to partial applies defined in the same function. At that point an attempt will be made to eliminate the partial apply altogether. For now, the pass does no work and is not part of any pipeline.
nate-chandler
force-pushed
the
add-mandatory-combiner-frame
branch
from
df105d8 to
211e656
Compare
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test and merge |
|
@swift-ci please smoke test OS X platform |
|
@swift-ci please clean smoke test OS X platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Minimal commit to get the mandatory combiner rolling. The intent of the mandatory combiner is to do basic transformations after the diagnostics passes have run at the beginning of both the Onone and the performance pipelines. For now, it simply visits reachable instructions and does no work.
In a subsequent commit, apply instructions will be processed and replaced if they are calls to partial applies defined in the same function. At that point an attempt will be made to eliminate the partial apply altogether.
For now, the pass does no work and is not part of any pipeline.