Unrevert "[Sema] Setter has incorrect mutating-ness inside class-constrained protocol extension" #27057
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s-constrained protocol extension"" This reverts commit edb153a.
jrose-apple
reviewed
Sep 6, 2019
jrose-apple
reviewed
Sep 6, 2019
…otocol requirement Do not offer a mutating fix-it if we have a mutating protocol requirement and we're assigning to it from an implicitly nonmutating setter inside a protocol extension
jrose-apple
reviewed
Sep 6, 2019
jrose-apple
reviewed
Sep 9, 2019
jrose-apple
reviewed
Sep 9, 2019
|
Thanks for sticking with this, by the way. Sorry for only noticing one or two things each time—I keep thinking "oh, this is an unrevert and it was basically ready to go in last time so I don't really need to look at it closely". |
…InContext()' instead
|
Running tests while I wait for approval: @swift-ci please smoke test |
|
@swift-ci please test source compatibility |
… a type context before proceeding
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
jrose-apple
reviewed
Sep 11, 2019
|
Alright, all tests have passed |
|
Is this good to merge now? Just need an approval before I do that (and fix the indentation). |
…the responsibility to the caller
jrose-apple
reviewed
Sep 17, 2019
…implifed by isInstanceMember()
jrose-apple
approved these changes
Sep 17, 2019
|
Thanks again for sticking with it! |
|
@swift-ci please test |
|
@swift-ci please test source compatibility |
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
This comment has been minimized.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This un-reverts #26695. The Core Team accepts this as a bug fix.
Resolves SR-11298.