Update the error message when subscripting String with Int. #27069
Conversation
Instead of referring to a doc comment that isn't really accessible to the developer, let's be accurate about what type they should be using here.
|
I think this is an improvement — it gives concrete, actionable feedback of what to you should do when you see this error. The doc comments have more detailed information about why these methods shouldn't exist. However, I'm not finding a way to view that content in Xcode or on developer.apple.com. Is that expected? |
|
IIRC the doc comments that have this info are on extensions, which don’t end up being attached to any particular symbol when SourceKit imports the module. Would this info make sense to move to the actual subscript docs? It feels a little weird to explain why an API isn’t written a different way, and there is an SE proposal to add |
|
@swift-ci Please smoke test and merge |
|
Looks like the smoke test failed because test/stdlib/UnavailableStringAPIs.swift.gyb is expecting the old error messages. |
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test |
Instead of referring to a doc comment that isn't really accessible to the developer, let's just be accurate about what type they should be using here.
rdar://problem/33715475