[ownership] Now that we can run -Onone tests with both ownership and … #27091
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…without, run pound_assert in both modes to prevent this test from breaking. I also extracted out the recursion test into a FileCheck test so that we can avoid having to do a -verify pattern match again the exact line where the recursion limit was hit. This limit is noisy in the face of codegen changes since we are IIRC counting instructions. Thus using -verify we can't pattern match since the line can change easily.
|
@swift-ci smoke test and merge |
|
LGTM. Thanks. |
ravikandhadai
approved these changes
Sep 9, 2019
|
@swift-ci smoke test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…without, run pound_assert in both modes to prevent this test from breaking.
I also extracted out the recursion test into a FileCheck test so that we can
avoid having to do a -verify pattern match again the exact line where the
recursion limit was hit. This limit is noisy in the face of codegen changes
since we are IIRC counting instructions. Thus using -verify we can't pattern
match since the line can change easily.