[semantic-arc-opts] Eliminate dead trivial instructions /after/ the m… #27094
Conversation
…ain loop to avoid issues around adding/removing things from the worklist. rdar://55127027
|
@swift-ci smoke test |
| if (!val) | ||
| continue; | ||
| recursivelyDeleteTriviallyDeadInstructions( | ||
| *val, true /*force*/, |
There was a problem hiding this comment.
Out of curiosity, why is force=true appropriate here? Also, why was it previously necessary to add operands and results to the worklist but is no longer?
There was a problem hiding this comment.
The reason why I put force here is b/c if I don't put force it just does the isTriviallyDead check again.
The reason why I removed the operand/result thing is I find with the test case in question that recursivelyDeleteTriviallyDeadInstructions can re-add the struct_extract from the test case to the worklist as a result of an instruction.
I just avoided all of the problems by doing it later.
There was a problem hiding this comment.
The reason why I put force here is b/c if I don't put force it just does the isTriviallyDead check again.
Anytime we violate the spirit of the API like this there should be a comment explaining the cleverness.
…ain loop to avoid issues around adding/removing things from the worklist.
rdar://55127027