[Diagnostics] Tailored diagnostic for "condition" expression #27107
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Unfortunately this has to wait until #27063 lands. |
Since all condition expressions supposed to be convertible to `Bool`, let's use that type as contextual and produce a tailored diagnostic.
Type-check of implicit `~=` has to be handled specially because constraint system doesn't yet have a full access to pattern-matching context where `~=` is used which would produce incorrect diagnostics.
xedin
force-pushed
the
if-conditional-diag
branch
from
f6819b8 to
232185e
Compare
|
@swift-ci please smoke test |
hborla
approved these changes
Sep 20, 2019
|
@swift-ci please smoke test macOS platform |
|
Looks like the Python lint failure should be fixed by #27278 |
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Since all condition expressions supposed to be convertible
to
Bool, let's use that type as contextual and produce atailored diagnostic.