Serialization: recover from missing modules when reading SubstitutionMaps [5.1 08-28] #27111
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Maps Harden more of the serialization functions to propagate errors for the caller to handle these errors gracefully. This fixes a crash in finishNormalConformance when indexing a system module with an implementation-only import. rdar://problem/52837313
|
@swift-ci Please test |
tkremenek
approved these changes
Sep 12, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Recover from deserialization errors when reading conformances using types and decls from a module behind an implementation-only importation. The compiler crashed when indexing a system module with requirements that should not be exposed to the clients. We don’t see this issue as often publicly because the textual swiftinterface hides those requirements.
Scope of the issue: This prevents internal developers of building SwiftUI apps with the default compiler arguments.
Risk: Low, the patch silences errors that previously crashed the compiler.
Reviewed-by: @jrose-apple and @harlanhaskins
Radar: rdar://problem/52837313