[docs] CToSwift: CF types, protocols, and swift_private #27118
Conversation
It's used all over the place in name importing, not just for enums.
docs/CToSwiftNameTranslation.md
Outdated
|
|
||
| _The original intent of the `swift_private` attribute was additionally to limit access to a Swift module with the same name as the owning Clang module, e.g. the Swift half of a mixed-source framework. However, this restriction has not been implemented as of Swift 5.1._ | ||
|
|
||
| _For "historical reasons", the `swift_private` attribute is ignored on factory initializers with no arguments._ |
There was a problem hiding this comment.
I traced this back to 91d1c3b, and it looks like there's no motivation for this; it was just "we forgot to implement it in the factory-method-to-initializer transformation and then didn't want to break anyone who wrote swift_private on a factory method and saw no effect". The code lives in ImportName.cpp today; that's where I got the "historical reasons" phrasing from.
There was a problem hiding this comment.
Your phrasing uses "factory initializers", is it the same as "factory methods"?
There was a problem hiding this comment.
Mm, not quite, because only some factory methods are imported as initializers. And that section hasn't been written yet. I can expand it out to "factory methods with no arguments that are imported as initializers", though.
docs/CToSwiftNameTranslation.md
Outdated
|
|
||
| _The original intent of the `swift_private` attribute was additionally to limit access to a Swift module with the same name as the owning Clang module, e.g. the Swift half of a mixed-source framework. However, this restriction has not been implemented as of Swift 5.1._ | ||
|
|
||
| _For "historical reasons", the `swift_private` attribute is ignored on factory initializers with no arguments._ |
There was a problem hiding this comment.
Your phrasing uses "factory initializers", is it the same as "factory methods"?
jrose-apple
force-pushed
the
translation-reflection-but-what-about-rotation
branch
from
e5bb756 to
2d63ae4
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test macOS |
jrose-apple
deleted the
translation-reflection-but-what-about-rotation
branch
Basically, all the remaining easy cases. See #26947 for what else belongs in this document.