[5.1] [Serialization] Teach serialization to get a generic signature from opaque types #27119
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please test |
|
Build failed |
|
Build failed |
harlanhaskins
changed the title
added 2 commits
September 11, 2019 15:43
…YPE_PATH_PIECE We might have an opaque return type path piece after a generic type param type, so make sure to emit the XREF entry before the opaque return type path piece as well. Fixes rdar://53958358
…paque types Previously, if we had an XREF to an opaque type, we would fail trying to get the generic signature from that type. Fixes rdar://53958358
harlanhaskins
force-pushed
the
xref-vision-5.1
branch
from
dd0db3b to
b59a33e
Compare
|
@swift-ci please test |
|
Build failed |
|
Build failed |
|
@swift-ci please nominate |
|
@tkremenek Looks like we never got this in. Can you approve this PR as well? (We pulled PR #27141 into swift-5.1-branch-08-28-2019) |
|
@tkremenek Ping |
DougGregor
approved these changes
Oct 8, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description: Fixes incorrect serialization of opaque return types for @inlinable code, and teaches serialization how to deserialize a generic signature from an opaque result type.
Scope of the issue: This prevents returning opaque result types from some @inlinable declarations when in incremental mode
Risk: Low, the patch ensures we start a cross-reference correctly regardless if the return type of a function is an opaque return type, and that we're able to deserialize it
Testing: Manually compiling projects using SwiftUI with @inlinable declarations and CI testing of reduced reproduction cases.
Reviewed-by: @jckarter
Radar: rdar://53958358