AST: promote API/ABI impact bit of decl attributes to AST, NFC #27124
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
If you're doing this, it might be worth separating APIBreakingToAdd from APIBreakingToRemove (and similar for ABI). |
|
@jrose-apple Yeah. The existing attributes are breakages in both ways, but separating them like what you mentioned is future-proof. |
nkcsgexi
force-pushed
the
promote-abi-impact-attribute
branch
from
d4bb94c to
f49e2d5
Compare
|
@jrose-apple Now we have four attributes: @harlanhaskins Feel free to specify |
|
@swift-ci please smoke test |
jrose-apple
reviewed
Sep 12, 2019
nkcsgexi
force-pushed
the
promote-abi-impact-attribute
branch
2 times, most recently
from
6498ca7 to
bc08b30
Compare
|
@swift-ci please smoke test |
ABI/API checker used to hard-code whether adding or removing of a decl attribute could break the existing ABI/API. This is not ideal because new attributes may be added to AST without updating the checker. After this change, new decl attribute could be specified whether it has ABI/API impact and the checker could pick up the knowledge instantly.
nkcsgexi
force-pushed
the
promote-abi-impact-attribute
branch
from
bc08b30 to
4189b6c
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ABI/API checker used to hard-code whether adding or removing of a
decl attribute could break the existing ABI/API. This is not ideal because
new attributes may be added to AST without updating the checker. After this
change, new decl attribute could be specified whether it has ABI/API
impact and the checker could pick up the knowledge instantly.