[NFC NameLookup ASTScope] Fixes for large app, eager primary tree creation, memberCount fix. #27143
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Can you add reduced test cases for the bugs you fixed? |
davidungar
force-pushed
the
A-9-12-eager-off
branch
from
bb0dafa to
35dd464
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test |
added 7 commits
September 13, 2019 16:19
davidungar
force-pushed
the
A-9-12-eager-off
branch
from
e9f4f47 to
771a381
Compare
|
@swift-ci please smoke test |
|
@slavapestov I have split up the commits, as you suggested (offline). I'll think about tests, but may not come up with any. For this PR, with ASTScopes disabled, the bugs are moot. The |
davidungar
force-pushed
the
A-9-12-eager-off
branch
from
771a381 to
e8cb103
Compare
|
@swift-ci please smoke test |
|
@swift-ci please smoke test OS X platform |
|
@swift-ci please smoke test linux platform |
1 similar comment
|
@swift-ci please smoke test linux platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Latest ASTScope lookup code, disabled-by-default. Includes fixes for bugs exposed when compiling a large app, and also fixes for other changes made to the source base.