[CSRanking] Always rank key path dynamic member choices lower than no… #27146
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
xedin
commented
Sep 12, 2019
…n-dynamic ones This only comes into play when all other choices are coming from constrained extensions, because there is no way to determine upfront whether any are going to match it's better to be safe and add key path dynamic member choice to the set too. Resolves: [SR-11465](https://bugs.swift.org/browse/SR-11465) Resolves: rdar://problem/55314724
xedin
force-pushed
the
dynamic-member-vs-contrained-ext
branch
from
2946da6 to
868afc6
Compare
|
@swift-ci please smoke test |
|
@swift-ci please test source compatibility |
DougGregor
approved these changes
Sep 12, 2019
|
@swift-ci please smoke test macOS platform |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…n-dynamic ones
This only comes into play when all other choices are coming from
constrained extensions, because there is no way to determine upfront
whether any are going to match it's better to be safe and add
key path dynamic member choice to the set too.
Resolves: SR-11465
Resolves: rdar://problem/55314724