Fix warnings #27152
Merged
Fix warnings #27152
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
compnerd
approved these changes
Sep 12, 2019
| #elif SWIFT_COMPILER_IS_MSVC | ||
| #pragma warning(push) | ||
| #pragma warning(disable : 4996) | ||
| #endif |
There was a problem hiding this comment.
I can't believe I never thought of this. This is a great idea!
|
@swift-ci please smoke test |
jrose-apple
reviewed
Sep 12, 2019
save-buffer
force-pushed
the
fix_warnings
branch
2 times, most recently
from
b9a70cf to
cc45e50
Compare
compnerd
reviewed
Sep 13, 2019
lib/AST/ASTScope.cpp
Outdated
| #pragma warning(disable : 4996) | ||
| #endif | ||
|
|
||
| LLVM_ATTRIBUTE_DEPRECATED( |
There was a problem hiding this comment.
Can we place this on the declaration instead of the definition?
There was a problem hiding this comment.
OK so looks like declaration was already marked with this, and testing with clang-cl doesn't produce this warning. Therefore, I think we only have to worry about it if it's MSVC.
lib/SIL/SILPrinter.cpp
Outdated
| #pragma warning(disable : 4996) | ||
| #endif | ||
|
|
||
| LLVM_ATTRIBUTE_DEPRECATED( |
added 9 commits
September 13, 2019 09:57
save-buffer
force-pushed
the
fix_warnings
branch
from
cc45e50 to
edc26bb
Compare
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bunch of warnings, most of them complaining about not all code paths returning a value. Also fixes complaints about
dumpbeing for use only in the debugger when onedumpfunction calls another.