[Frontend] Avoid doing whole-module work under primary-file typecheck #27153
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
...a situation we get into with indexing. The way Xcode generates indexing invocations is to take a build command and add additional flags to it; in order for the Driver to produce a single frontend command from /that/, it currently plans as if it's going to do a whole-module -typecheck and then turns around and uses -primary-file anyway. This is questionable practice, to be sure... ...but meanwhile, let's not crash by trying to access declarations that haven't been type-checked yet. rdar://problem/53117124
|
@swift-ci Please test |
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Sep 13, 2019
…swiftlang#27153) ...a situation we get into with indexing. The way Xcode generates indexing invocations is to take a build command and add additional flags to it; in order for the Driver to produce a single frontend command from /that/, it currently plans as if it's going to do a whole-module -typecheck and then turns around and uses -primary-file anyway. This is questionable practice, to be sure... ...but meanwhile, let's not crash by trying to access declarations that haven't been type-checked yet. rdar://problem/53117124 (cherry picked from commit 9e6d4db)
jrose-apple
added a commit
to jrose-apple/swift
that referenced
this pull request
Sep 13, 2019
…swiftlang#27153) ...a situation we get into with indexing. The way Xcode generates indexing invocations is to take a build command and add additional flags to it; in order for the Driver to produce a single frontend command from /that/, it currently plans as if it's going to do a whole-module -typecheck and then turns around and uses -primary-file anyway. This is questionable practice, to be sure... ...but meanwhile, let's not crash by trying to access declarations that haven't been type-checked yet. rdar://problem/53117124 (cherry picked from commit 9e6d4db)
davidungar
reviewed
Sep 13, 2019
| Invocation, | ||
| moduleIsPublic)) { | ||
| return true; | ||
| if (opts.InputsAndOutputs.isWholeModule()) { |
There was a problem hiding this comment.
Would be nice to explain why this test is here in a comment.
|
As I wrote, I think a comment explaining the reason for the new guard would be very nice. It is unguessable.
- David
… On Sep 12, 2019, at 5:53 PM, Jordan Rose ***@***.***> wrote:
Merged #27153 into master.
—
You are receiving this because your review was requested.
Reply to this email directly, view it on GitHub, or mute the thread.
|
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...a situation we get into with indexing. The way Xcode generates indexing invocations is to take a build command and add additional flags to it; in order for the Driver to produce a single frontend command from that, it currently plans as if it's going to do a whole-module -typecheck and then turns around and uses -primary-file anyway. This is questionable practice, to be sure...
...but meanwhile, let's not crash by trying to access declarations that haven't been type-checked yet.
rdar://problem/53117124