-
Notifications
You must be signed in to change notification settings - Fork 10.5k
Remove stdlib and runtime dependencies on Foundation and CF #27155
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
@swift-ci please test |
@swift-ci please benchmark |
Performance: -O
Code size: -OPerformance: -Osize
Code size: -OsizePerformance: -Onone
Code size: -swiftlibs
How to read the dataThe tables contain differences in performance which are larger than 8% and differences in code size which are larger than 1%.If you see any unexpected regressions, you should consider fixing the Noise: Sometimes the performance results (not code size!) contain false Hardware Overview
|
Build failed |
33a0043
to
1efa946
Compare
@swift-ci please test |
Build failed |
Build failed |
Build failed |
@swift-ci please test osx platform |
@swift-ci please test os x platform |
/// Convert to an NSArray. | ||
/// | ||
/// - Precondition: `Element` is bridged to Objective-C. | ||
/// | ||
/// - Complexity: O(1). | ||
@inlinable | ||
@usableFromInline |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know this seems pedantic, but could you add a comment after the @usableFromInline
? Something to the effect of:
@usableFromInline // was @inlinable through Swift 5.1 (see comment below)
I want some indication right on the decl of the binary compatibility story, without reading comments inside the body (which may be about the implementation).
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we also mark these deprecated at this point, with a message that explains why they're there and not to use them?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Can we mark things as deprecated without breaking our own/Foundation's callsites?
Congrats! |
Relanding #26630, with some fixes and improvements (now also decouples from CF properly!)
Fixes rdar://34198279