[Compatibility50] Look up swift_getObjCClassMetadata at runtime. #27170
Conversation
|
When does this come up? Should we be linking the compatibility library in the first place in this situation? swiftpm for instance should be set up to disable linking the compatibility library when linking a pure C/ObjC target. |
|
Also, does libswiftCore.dylib properly load override hooks when it's dynamically dlopened? |
|
My main concern about this is that it may very well not scale. The 5.0 compatibility library currently has only one dependency on |
|
The hooks do indeed work when the runtime is dlopened. As for when this comes up, xctest needs to link this library so tests can benefit from the fixes. The hooks only work in the main executable, so linking them into the test bundle wouldn’t work. Scaling this up would get messy but I’m not sure if there’s a better way. I’m certainly open to suggestions in any case. |
This is the only dependency it has on libswiftCore. Looking this up at runtime allows its use in programs that don't link libswiftCore but might eventually load and run Swift code, such as xctest. While we're in there, enable tests in files ending with `.c`. rdar://problem/55274114
mikeash
force-pushed
the
the-missing-link
branch
from
bb5743a to
c9f9350
Compare
|
@swift-ci please test |
This is the only dependency it has on libswiftCore. Looking this up at runtime allows its use in programs that don't link libswiftCore but might eventually load and run Swift code, such as xctest.
While we're in there, enable tests in files ending with
.c.rdar://problem/55274114