Skip to content

NFC: Excise ParseableInterface from code #27175

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

harlanhaskins
Copy link
Contributor

This PR does a few cleanups to module interface loading

  • Splits ModuleInterfaceBuilder to its own file, separate from ModuleInterfaceLoader
  • Renames ParseableInterface{Builder,Loader} to ModuleInterface{Builder,Loader}
  • Removes instances of 'parseable interface' or 'parseable module' from the codebase
  • Moves the test folder
  • Updates the tests to stop using emit-parseable-module-interface-path and build-module-from-parseable-interface

Harlan Haskins added 5 commits September 13, 2019 11:45
NFC, they were just separate enough to warrant splitting into their own
file.
…oader

Rename this class to better fit the user-facing name.
Rename ParseableInterfaceBuilder to accompany ModuleInterfaceLoader
…here

Now that we've settled on Module Interface as the name, let's remove the
vestiges of "Parseable Interfaces"
Also remove uses of -emit-parseable-module-interface from tests
harlanhaskins pushed a commit to harlanhaskins/swift-lldb that referenced this pull request Sep 14, 2019
This patch adopts the new APIs in swiftlang/swift#27175
and removes the usage of `-emit-parseable-module-interface[-path]` in
favor of the final flags, `-emit-module-interface[-path]`.
@harlanhaskins
Copy link
Contributor Author

apple/swift-lldb#1988

@swift-ci please test

@harlanhaskins harlanhaskins merged commit 8aa5cae into swiftlang:master Sep 14, 2019
harlanhaskins pushed a commit to apple/swift-lldb that referenced this pull request Sep 14, 2019
This patch adopts the new APIs in swiftlang/swift#27175
and removes the usage of `-emit-parseable-module-interface[-path]` in
favor of the final flags, `-emit-module-interface[-path]`.
vedantk pushed a commit to apple/swift-lldb that referenced this pull request Sep 17, 2019
This patch adopts the new APIs in swiftlang/swift#27175
and removes the usage of `-emit-parseable-module-interface[-path]` in
favor of the final flags, `-emit-module-interface[-path]`.

(cherry picked from commit 3a3b6fa)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants