IRGen: Fix Clang type conversion to map Swift.Bool to _Bool instead o… #2718
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…f signed char CoreFoundation on Linux expects this. I'm not sure what changed recently to expose this problem -- and I *am* sure that this workaround is not the right way of doing it. However, the public CI on Linux has been broken for a week now because of this, so let's get it passing again so we can investigate what changed in Clang/LLVM here. Fixes <rdar://problem/26444628>.
|
@swift-ci Please test |
1 task
|
You can put me down as the reviewer if the preview branch is having the same issue. |
|
I assume |
|
But we can worry about that later. |
|
Does the fix look OK in general, @jrose-apple? |
|
Oops, I forgot to reload so I didn't see your replies earlier. Please disregard. |
|
Hi @tkremenek, do we want this to go into swift-3.0-preview-1-branch also? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
rdar://problem/26444628
Please don't merge -- still needs tests (and might be the wrong approach)