Skip to content

[PrintAsObjC] Separate out module contents printing too #27184

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 14, 2019

Conversation

jrose-apple
Copy link
Contributor

The top-level PrintAsObjC now just covers import printing and the near-literal prologue/epilogue text, while the decl printing (and import collecting) is in its own file. No functionality change.

(Previously: #27163)

The top-level PrintAsObjC now just covers import printing and the
near-literal prologue/epilogue text, while the decl printing (and
import collecting) is in its own file. No functionality change.
@jrose-apple
Copy link
Contributor Author

Note: The PrintAsObjC.cpp diff is easier to read if you ignore whitespace changes.

@swift-ci Please smoke test

@jrose-apple
Copy link
Contributor Author

@swift-ci Please test source compatibility

Copy link
Contributor

@varungandhi-apple varungandhi-apple left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I'm slightly surprised at the line count difference -- eyeballing the changes would've made me think it overall adds <50 lines, but there is a net +82 lines.

@jrose-apple
Copy link
Contributor Author

I'm slightly surprised at the line count difference -- eyeballing the changes would've made me think it overall adds <50 lines, but there is a net +82 lines.

Some lines were changed to protect the innocent adjust to the new interface. I think that accounts for it.

@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test macOS

@jrose-apple jrose-apple merged commit 83e7763 into swiftlang:master Sep 14, 2019
@jrose-apple jrose-apple deleted the laserwriter-ii branch September 14, 2019 03:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants