Skip to content

runtime: add a workaround for Windows build #27196

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 16, 2019
Merged

Conversation

compnerd
Copy link
Member

The runtime tests will statically link the runtime and dynamically link
to the standard library. This fails to build on Windows. This is a
horrible workaround for the time being.

Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.

Resolves SR-NNNN.

The runtime tests will statically link the runtime and dynamically link
to the standard library.  This fails to build on Windows.  This is a
horrible workaround for the time being.
@compnerd
Copy link
Member Author

@swift-ci please smoke test

@compnerd
Copy link
Member Author

@swift-ci please test Windows platform

@compnerd
Copy link
Member Author

CC: @jckarter

@jckarter
Copy link
Contributor

IIRC there's a macro that's defined while building the runtime for the standard library. Could we conditionalize this on that macro so we don't need dllimport in the standard library copy?

@compnerd
Copy link
Member Author

@jckarter - I would love to do that. This seems fundamentally wrong. However, I don't think that we build the runtime twice, so I'm afraid that Im not following what you are suggesting.

@jckarter
Copy link
Contributor

Hm, I thought we did rebuild the runtime object files when building for SwiftRuntimeTests, because there have been other linking problems that we've needed to deal with due to the different requirements of SwiftRuntimeTests vs. everything else, but maybe I'm mistaken.

@compnerd
Copy link
Member Author

Going to merge this for now, I'll take a look into that and adjust it if I can.

@compnerd compnerd merged commit bf1ab6c into swiftlang:master Sep 16, 2019
@compnerd compnerd deleted the 27185 branch September 16, 2019 20:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants