[Constant Evaluator][Tests] Add tests to check constant evaluability of Swift code snippets #27208
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
1. builtin "int_expect", which makes the evaluator work on more integer operations such as left/right shift (with traps) and integer conversions. 2. builtin "_assertConfiguration", which enables the evaluator to work with debug stdlib. 3. builtin "ptrtoint", which enables the evaluator to track StaticString 4. _assertionFailure API, which enables the evaluator to report stdlib assertion failures encountered during constant evaluation. Also, enable attaching auxiliary data with the enum "UnknownReason" and use it to improve diagnostics for UnknownSymbolicValues, which represent failures during constant evaluation.
|
@swift-ci Please test |
…ility of Swift code snippets. Add a new test: constant_evaluable_subset_test.swift that tests Swift code snippets that are expected to be constant evaluable and those that are not.
ravikandhadai
force-pushed
the
constexpr-fragment-check
branch
from
37736f3 to
032442d
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a new sil-opt pass:
ConstantEvaluableSubsetCheck.cppto check constant evaluability of Swift code snippets. This pass is only used in tests and will eventually replacepound_assert.swifttests.This PR also adds a new test:
constant_evaluable_subset_test.swiftthat contains Swift code snippets that are expected to be constant evaluable and those that are not. The goal of this test is to document Swift code snippets known to be constant evaluable (and not) and catch any regressions in the SILGen and mandatory passes that could change the constant evaluability of these code snippets.(See only the most recent commit in this PR, which has the relevant changes.)