[OSLog][Test] Add test to check constant evaluability of functions in the new OSLog overlay #27228
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
theblixguy
reviewed
Sep 18, 2019
include/swift/AST/DiagnosticsSIL.def
Outdated
| NOTE(constexpr_unknown_function_called_here, none, | ||
| NOTE(constexpr_found_callee_with_no_body, none, | ||
| "encountered call to '%0' whose body is not available. " | ||
| "Imported functions must be marked @inlinable to constant evaluate.", |
There was a problem hiding this comment.
Nit: attributes should be surrounded with single quotes. Might be worth adding a fix-it as well.
There was a problem hiding this comment.
Thanks @theblixguy
include/swift/AST/DiagnosticsSIL.def
Outdated
| ERROR(not_constant_evaluable, none, "not constant evaluable", ()) | ||
| ERROR(constexpr_imported_func_not_onone, none, "imported constant evaluable " | ||
| "function '%0' must be annotated @_optimize(none)", (StringRef)) |
There was a problem hiding this comment.
Same here. Also, “annotated with”
|
Build failed |
@_semantics("constant_evaluable") annotation to denote constant
evaluable functions.
Add a test suite that uses the sil-opt pass ConstantEvaluableSubsetChecker.cpp
to check the constant evaluability of function in the OSLog
overlay.
ravikandhadai
force-pushed
the
constexpr-oslog-constant-evaluable-check
branch
from
59020e9 to
61fd4b1
Compare
|
@swift-ci Please test and merge |
1 similar comment
|
@swift-ci Please test and merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update the new oslog overlay implementation to use @_semantics("constant_evaluable") annotation to denote constant evaluable functions.
Add a new test that uses the sil-opt pass ConstantEvaluableSubsetChecker.cpp
to check the constant evaluability of functions in the OSLog overlay.