ReflectionContext: Remove platform #ifs for image format checks. #27237
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
In principle, swift-reflection-* ought to work with cross-compiled binaries. Dispatch out to reading MachO, PE, or ELF section metadata based on the magic of an image passed to `addImage` instead of using #ifs to pick an implementation based on the host platform. (This still doesn't fully address other host/target differences like word size or endianness, but is progress toward making the tool target-agnostic.)
|
@swift-ci Please test |
|
@swift-ci Please test Windows |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In principle, swift-reflection-* ought to work with cross-compiled binaries. Dispatch out to reading
MachO, PE, or ELF section metadata based on the magic of an image passed to
addImageinstead of using #ifs to pick an implementation based on the host platform. (This still doesn't fully address other host/target differences like word size or endianness, but is progress toward making the tool target-agnostic.)