[NFC] Address review feedback from #27172 #27241
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- Clean up some errant formatting mistakes. - Collapse some code that was duplicating computing the interface type.
|
@swift-ci please smoke test and merge |
slavapestov
approved these changes
Sep 18, 2019
| // suffices. Otherwise we'll potentially try to validate incomplete | ||
| // requirements. | ||
| auto *proto = dyn_cast_or_null<ProtocolDecl>( | ||
| typealias->getDeclContext()->getAsDecl()); |
There was a problem hiding this comment.
One more nitpick: This should be dyn_cast<ProtocolDecl>(typealias->getDeclContext())
There was a problem hiding this comment.
or typealias->getSelfProtocolDecl() :)
| ? extendedType | ||
| : ty->getDecl()->getDeclaredType(); | ||
| if (auto ty = aliasDecl->getStructuralType() | ||
| ->getAs<NominalOrBoundGenericNominalType>()) |
There was a problem hiding this comment.
getNominalOrBoundGenericNominal()
There was a problem hiding this comment.
That canonicalizes the type. I only want to desugar it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The dumper kicking off requests is going to require a more holistic patch.