[ASTGen] Adjust geneate() function signatures #27291
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
'generate()' receives `const` reference to `SomeSyntax`. This should prevent unnecessary reference counter operations.
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
rintaro
added a commit
to rintaro/swift
that referenced
this pull request
Oct 14, 2019
…xparses-astgen-signature"" This reverts commit 0165b4f.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
generate()functions now receiveconstreference. This should prevent unnecessary reference counter operations.