Skip to content

Using %sil-opt is inconsistent with the rest of the tests in this directory #27296

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Sep 24, 2019

Conversation

ematejska
Copy link
Contributor

Using %sil-opt is inconsistent with the rest of the tests in this directory which use %target-sil-opt. This causes problems if some lit systems don't recognize %sil-opt and only recognize %target-sil-opt. Updating for consistency.

…ectory which use %target-sil-opt. This causes problems if some lit systems don't recognize %sil-opt and only recognize %target-sil-opt. Updating for consistency.
@ematejska
Copy link
Contributor Author

@swift-ci please test

@ematejska
Copy link
Contributor Author

@swift-ci please smoke test

@ematejska ematejska requested a review from gottesmm September 23, 2019 05:49
Copy link
Contributor

@gottesmm gottesmm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@ematejska ematejska merged commit be87bd1 into swiftlang:master Sep 24, 2019
@ematejska ematejska deleted the update_sil_test_naming branch September 24, 2019 21:41
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants