Skip to content

[IDE] Fix ModelASTWalker passing syntax nodes before the corresponding AST nodes have been visited #27329

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

nathawes
Copy link
Contributor

This was causing the tokens comprising image literals to be output separately, rather than as a single object literal.

Resolves rdar://problem/55045797

…g AST nodes had been visited

This was causing the tokens comprising image literals to be output separately,
rather than as a single object literal.

Resolves rdar://problem/55045797
@nathawes nathawes requested a review from nkcsgexi September 24, 2019 18:50
@nathawes
Copy link
Contributor Author

@swift-ci please test

@nathawes nathawes changed the title [IDE] Fix ModelASTWalker passing syntax nodes before the corresponding AST nodes had been visited [IDE] Fix ModelASTWalker passing syntax nodes before the corresponding AST nodes have been visited Sep 24, 2019
@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 888529c

@nathawes
Copy link
Contributor Author

@swift-ci please test OS X Platform

@nathawes nathawes merged commit 03bdd1c into swiftlang:master Sep 24, 2019
@nathawes nathawes deleted the r55045797-image-literal-syntax-map branch September 24, 2019 20:58
@nathawes nathawes restored the r55045797-image-literal-syntax-map branch September 24, 2019 21:03
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants