Ignore fixits for adding objc(selector) when doing migration, and fixits for mismatch label in overridden method #2734
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… is messing with argument labels.
…adding @objc(selector). These interact badly with the swift migrator, they are triggered by label mismatches in pre-migrated code. We also don't generally need them since we do inference for the most common cases.
|
@swift-ci smoke test os x platform |
MaxDesiatov
pushed a commit
that referenced
this pull request
Apr 19, 2021
[pull] swiftwasm from main
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What's in this pull request?
When picking-up fixits for migration ignore the fixits for adding @objc(selector).
These interact badly with the swift migrator, they are triggered by label mismatches in pre-migrated code.
We also don't generally need them since we do inference for the most common cases. The case where the inference may not work is un-idiomatic and rare (you would have the conforming method in the class but the protocol would show up in an extension in a different file instead of in the class.
Also ignore another diagnostic that is ‘correcting’ argument labels
Resolved bug number: (SR-)
rdar://26508866
Before merging this pull request to apple/swift repository: