Skip to content

Debug Info: Encode let-bindings using DW_TAG_const_type. #27345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 27, 2019
Merged

Debug Info: Encode let-bindings using DW_TAG_const_type. #27345

merged 1 commit into from
Sep 27, 2019

Conversation

adrian-prantl
Copy link
Contributor

This allows the debugger to distinguish constant "let" values from mutable "var" variables.

rdar://problem/16042546

@adrian-prantl adrian-prantl mentioned this pull request Sep 24, 2019
Merged
@adrian-prantl
Copy link
Contributor Author

test with apple/swift-lldb#2015

@adrian-prantl
Copy link
Contributor Author

Sorry for the long patch, it will get shorter, once #27238 has landed.

@adrian-prantl
Copy link
Contributor Author

test with apple/swift-lldb#2015
@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - ba52022f6144c238458992afdd51875ac8bbc4ff

@adrian-prantl
Copy link
Contributor Author

test with apple/swift-lldb#2015
@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 9bd1231a1efb72b6655f9a4388e62d16e9f48cb3

@adrian-prantl
Copy link
Contributor Author

test with apple/swift-lldb#2015
@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 2434f1772d6608d0727ca3c7251f522ffee74311

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - ba52022f6144c238458992afdd51875ac8bbc4ff

@adrian-prantl
Copy link
Contributor Author

test with apple/swift-lldb#2015
@swift-ci test

@adrian-prantl
Debug Info: Encode let-bindings using DW_TAG_const_type.
ff22da2 
This allows the debugger to distinguish constant "let" values from
mutable "var" variables.

rdar://problem/16042546
@adrian-prantl
Copy link
Contributor Author

test with apple/swift-lldb#2015
@swift-ci test

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - dadf3d6ff775c3e59eb70ca7be0728bc065ebd38

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - dadf3d6ff775c3e59eb70ca7be0728bc065ebd38

dcci
dcci approved these changes Sep 27, 2019
View reviewed changes
Copy link
Member

@dcci dcci left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The compiler bits look good to me.

@adrian-prantl adrian-prantl changed the base branch from master to master-rebranch September 27, 2019 21:39
@adrian-prantl adrian-prantl merged commit 00c64e7 into swiftlang:master-rebranch Sep 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dcci dcci dcci approved these changes

@slavapestov slavapestov Awaiting requested review from slavapestov

@jimingham jimingham Awaiting requested review from jimingham

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@adrian-prantl @swift-ci @dcci