Requestify Operator Precedence Groups and Precedence Group Lookup #27351
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Define the LookupPrecedenceGroupRequest and OperatorPrecedenceGroupRequest for looking up an unvalidated precedence group declaration and retrieving then validating the precedence group associated with an operator. This allows us to drop both validateDecl overloads for these types out of the TypeChechecker
|
@swift-ci please smoke test |
|
This is a nightmarish diff... |
Restructure the way operators and precedencegroup declarations are validated. First, factor out the common operator validation code into the DeclChecker. Then, redo the lookup and validation code for precedence groups to work with the request model. Finally, delete the validateDecl overloads on the TypeChecker. Unfortunately, the evaluator is not capable of detecting all the cycles TypeCheckDecl can. In particular, certain cross-file precedence group cycles cannot be diagnosed via request alone. That infrastructure all stays in place.
CodaFi
force-pushed
the
not-a-good-start-boris
branch
from
8d9a499 to
d992ff3
Compare
|
@swift-ci please smoke test |
|
Package errors seem unrelated. Will give it another shot later. |
|
@swift-ci please smoke test Linux platform |
|
⛵️ |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Define the LookupPrecedenceGroupRequest and OperatorPrecedenceGroupRequest for looking up an unvalidated precedence group declaration and retrieving then validating the precedence group associated with an operator respectively.
This restructures the way that we validate operator declarations and precedence group declarations. In particular, the interface the type checker vends to look up an operator will now also validate that operator rather than return it raw and expect the client to do the right thing.
This allows the remaining overloads of
validateDeclto be deleted and retracted into the decl checker.There are now 2 remaining calls to validateDecl.