[ClangImporter] Remove manual setting of Protocol Self depth #27352
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
At one point in the past we probably needed to set this explicitly, but now it seems to be handled for us or derived somewhere. No functionality change.
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
CodaFi
approved these changes
Sep 25, 2019
|
I'm counting on existing assertions and verifier checks to catch anything that went wrong. It's weird that the importer ever had to do it in the first place, so an assertion here doesn't make sense. |
slavapestov
approved these changes
Sep 25, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
At one point in the past we probably needed to set this explicitly, but now it seems to be handled for us or derived somewhere.
No functionality change.