[ClangImporter] Use external_source_symbol to identify Swift decls #27355
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please test |
|
@swift-ci Please test source compatibility |
|
Build failed |
|
I really thought I tested that. I'll update it later today. |
...rather than replacing particular macros with an 'annotate' attribute and then looking for that. This isn't /really/ any particular win except maybe ever-so-slightly faster module imports (with one fewer attribute being added to each declaration in a mixed-source header). This doesn't remove the SWIFT_CLASS_EXTRA, SWIFT_PROTOCOL_EXTRA, or SWIFT_ENUM_EXTRA macros from PrintAsObjC (note that SWIFT_EXTENSION_EXTRA was never used). They're not exactly needed anymore, but they're not doing any harm if someone else is using them.
jrose-apple
force-pushed
the
i-still-cannot-believe-pragma-clang-attribute-push-is-a-thing
branch
from
62bd812 to
7b2f63f
Compare
|
@swift-ci Please test |
|
Build failed |
|
Build failed |
beccadax
reviewed
Sep 25, 2019
xymus
approved these changes
Sep 25, 2019
nkcsgexi
approved these changes
Sep 25, 2019
akyrtzi
approved these changes
Sep 25, 2019
|
@swift-ci Please test macOS |
beccadax
approved these changes
Sep 25, 2019
jrose-apple
deleted the
i-still-cannot-believe-pragma-clang-attribute-push-is-a-thing
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
...rather than replacing particular macros with an
annotateattribute and then looking for that. This isn't really any particular win except maybe ever-so-slightly faster module imports (with one fewer attribute being added to each declaration in a mixed-source header).This doesn't remove the
SWIFT_CLASS_EXTRA,SWIFT_PROTOCOL_EXTRA, orSWIFT_ENUM_EXTRAmacros from PrintAsObjC (note thatSWIFT_EXTENSION_EXTRAwas never used). They're not exactly needed anymore, but they're not doing any harm if someone else is using them.