Circular validation cleanups, part 1 #27357
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…n-empty Type Return an ErrorType on circularity instead of Type().
This also gets rid of a usage of TypeAliasType::get().
…Type In the case of circular type aliases, this now returns ErrorType instead of Type().
slavapestov
force-pushed
the
circular-validation-cleanups
branch
from
4a8b002 to
5e49002
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please smoke test Linux |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please test source compatibility Debug |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm chipping away at validateDecl() cycles, so that we can have validateDecl() diagnose instead of silently returning if the declaration is already being validated. This PR has some preliminary cleanups.