AST: Types nested inside a subclass shadow types in the superclass with same name #27365
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
slavapestov
force-pushed
the
member-type-shadowing-rule
branch
from
d3ca83b to
c30dec3
Compare
…th same name The existing rules sometimes behaved this way, because validateDecl() bails out silently without error on circularity. Let's make this explicit instead, and get it working in all cases. Fixes <rdar://https://bugs.swift.org/browse/SR-3492> and <rdar://problem/45889192>.
…ogic There's no need to roll our own implementation here. Fixes <rdar://problem/16724197>.
slavapestov
force-pushed
the
member-type-shadowing-rule
branch
from
c30dec3 to
44827bb
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test macOS |
|
@swift-ci Please test source compatibility Release |
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The existing rules sometimes behaved this way, because validateDecl()
bails out silently without error on circularity.
Let's make this explicit instead, and get it working in all cases.
Fixes https://bugs.swift.org/browse/SR-3492, rdar://problem/16724197,
and rdar://problem/45889192.