Skip to content

Reflection: Traffic in RemoteRefs. #27369

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2019
Merged

Reflection: Traffic in RemoteRefs. #27369

merged 1 commit into from
Sep 26, 2019

Conversation

jckarter
Copy link
Contributor

Instead of passing around raw local pointers and references, and spreading
tricky offset arithmetic around with the Local/RemoteAddress fields in
ReflectionInfo, have the TypeRefBuilder code use RemoteRefs everywhere,
which keep the remote/local mapping together in one unit and provide
centralized API for this logic.

This doesn't yet change how code uses the RemoteRef address data to
follow pointers across objects, for things like reading type refs, but
that should be much easier to do after this lands.

@jckarter
Copy link
Contributor Author

@swift-ci Please test

@jckarter
Copy link
Contributor Author

@swift-ci Please test Windows

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 036a8e3972734a229664a08cfbc0d886dbfd2d6c

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 036a8e3972734a229664a08cfbc0d886dbfd2d6c

@jckarter jckarter force-pushed the type-ref-builder-remote-ref branch from 036a8e3 to 20f3bad Compare September 25, 2019 22:59
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@jckarter
Copy link
Contributor Author

@swift-ci Please test Windows

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 036a8e3972734a229664a08cfbc0d886dbfd2d6c

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 036a8e3972734a229664a08cfbc0d886dbfd2d6c

@jckarter
Reflection: Traffic in RemoteRefs.
8c4df3b 
Instead of passing around raw local pointers and references, and spreading
tricky offset arithmetic around with the Local/RemoteAddress fields in
ReflectionInfo, have the TypeRefBuilder code use RemoteRefs everywhere,
which keep the remote/local mapping together in one unit and provide
centralized API for this logic.

This doesn't yet change how code uses the RemoteRef address data to
follow pointers across objects, for things like reading type refs, but
that should be much easier to do after this lands.
@jckarter jckarter force-pushed the type-ref-builder-remote-ref branch from 20f3bad to 8c4df3b Compare September 26, 2019 03:28
@jckarter
Copy link
Contributor Author

@swift-ci Please test

@jckarter
Copy link
Contributor Author

@swift-ci Please test Windows

1 similar comment
@jckarter
Copy link
Contributor Author

@swift-ci Please test Windows

@swift-ci
Copy link
Contributor

Build failed
Swift Test OS X Platform
Git Sha - 20f3badcc63d3ad82fffdb6a905c6d97bbfd7b66

@swift-ci
Copy link
Contributor

Build failed
Swift Test Linux Platform
Git Sha - 20f3badcc63d3ad82fffdb6a905c6d97bbfd7b66

@jckarter
Copy link
Contributor Author

@swift-ci Please test Windows

@jckarter
Copy link
Contributor Author

@compnerd The "Please test Windows" bot seemed to be ignoring my requests after the first one yesterday up until I tried again this morning. Known problem?

@jckarter
Copy link
Contributor Author

These Windows test failures look unrelated:

    Swift(windows-x86_64) :: Driver/sourceinfo_file.swift
    Swift(windows-x86_64) :: Driver/merge-module.swift
    Swift(windows-x86_64) :: Driver/advanced_output_file_map.swift

https://ci-external.swift.org/job/swift-PR-windows/87/

@jckarter jckarter merged commit 02b5e56 into swiftlang:master Sep 26, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@jckarter @swift-ci