[AST] Break some header dependencies for faster rebuilds #27374
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
DiagnosticEngine.h no longer depends on Attr.h. Expr.h no longer depends on TypeRepr.h. No functionality change.
|
@swift-ci Please smoke test |
|
The original goal of this was to make Attr.def touch fewer files but I don't think I succeeded because of AttrKind.h. |
varungandhi-apple
approved these changes
Sep 26, 2019
CodaFi
approved these changes
Sep 26, 2019
|
Nothing so advanced, just find a header that bothers me and look wherever it's included in other headers (as opposed to .cpp files). If I can't break a link, see if I can break the next link after that. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DiagnosticEngine.h no longer depends on Attr.h.
Expr.h no longer depends on TypeRepr.h.
No functionality change.