Sema: Remove unnecessary circularity breaks #27379
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@CodaFi This isn't ready to merge yet because it depends on the request-ification of checkRawValues(). |
|
@swift-ci Please test source compatibility |
CodaFi
approved these changes
Sep 26, 2019
slavapestov
force-pushed
the
circular-validation-cleanups-2
branch
2 times, most recently
from
a272f1d to
3f9388e
Compare
We don't want hasBody() == true and getBody() == nullptr.
slavapestov
force-pushed
the
circular-validation-cleanups-2
branch
2 times, most recently
from
aec90d5 to
6702d38
Compare
|
@swift-ci Please smoke test |
|
@swift-ci Please test source compatibility |
|
@swift-ci Please smoke test macOS |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.