[Diagnostics] Centralize requirement failure impact assessment #27390
+83
−26
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Conformance requirements get their fixes attached directly where other requirements have to use (for now) `repairFailure` mechanism. Regardless of _how_ fixes get recorded there should be a single way to assess impact of a particular requirement failure. The rules are: - If this is a requirement associated with an operator, impact is based on use of the type which failed the requirement; - If this requirement is from conditional extension, it is considered a very high impact because failing such requirement makes referenced member de facto invisible. Resolves: rdar://problem/55593998 Resolves: [SR-11491](https://bugs.swift.org/browse/SR-11491)
|
@swift-ci please smoke test |
hborla
approved these changes
Sep 27, 2019
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Conformance requirements get their fixes attached directly where
other requirements have to use (for now)
repairFailuremechanism.Regardless of how fixes get recorded there should be a single
way to assess impact of a particular requirement failure.
The rules are:
If this is a requirement associated with an operator, impact
is based on use of the type which failed the requirement;
If this requirement is from conditional extension,
it is considered a very high impact because failing such
requirement makes referenced member de facto invisible.
Resolves: rdar://problem/55593998
Resolves: SR-11491