Update master to support apple/stable/20190619 branch for LLVM projects #27396
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
[Cherry-picking test changes from this commit.] This change uses the 'gather bits' functionality of enum payloads to create a contiguous value to switch over. This allows us to remove the code that currently attempts to build a switch statement by comparing each element in the payload in turn. The downside of this technique is that we may do more work up front gathering bits and we may also need to compare larger values in some situations. The upside is that we can remove a lot of complicated code from IRGen. Also, we pass the responsibility for multi-way branch generation to LLVM which can make use of a wider range of switch lowering strategies than IRGen can sensibly support. # Conflicts: # lib/IRGen/EnumPayload.cpp # test/IRGen/enum.sil
|
Build failed |
|
Build failed |
|
Linux Toolchain (Ubuntu 16.04) Install command |
1 similar comment
|
Build failed |
|
Build failed |
|
Linux Toolchain (Ubuntu 16.04) Install command |
|
macOS Toolchain Install command |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.