[Driver] Include more info in "crash because TMPDIR is borked" errors #27412
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci Please smoke test |
|
@swift-ci Please test Windows |
aciidgh
approved these changes
Sep 28, 2019
|
Whoops, guess "please test Windows" is down for now. (Too-old CMake.) |
Two places in Driver are creating temporary files at a point in the process where failure is not expected. We should do something better about this, but meanwhile harmonize their failures and include a little more info. Filed https://bugs.swift.org/browse/SR-11541 to improve this.
jrose-apple
force-pushed
the
last-will-and-testament
branch
from
78c6c8e to
44541e1
Compare
|
@swift-ci Please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Two places in Driver are creating temporary files at a point in the process where failure is not expected. We should do something better about this, but meanwhile harmonize their failures and include a little more info.
Filed SR-11541 to improve this.