[CS] Define a class for every locator path element kind #27433
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This allows us to define a `LocatorPathElt` subclass for each path element kind.
This makes it consistent with `getLastElementAs` and `castLastElementTo`.
Rename to LocatorPathElt::ProtocolRequirement in order to help avoid confusion with LocatorPathElt::AnyRequirement.
|
@swift-ci please smoke test |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This is a follow-up to #26297. This PR uses macros to define the different kinds of locator path elements, which then allows us to define a
LocatorPathEltsubclass for each one.ConstraintLocator::isLastElementis then changed to take aLocatorPathEltsubclass, making it consistent with the other last-element casting members.Finally this PR renames the
Requirementpath element toProtocolRequirementin order to help avoid confusion withAnyRequirement.