Skip to content

[windows][test] Use regexes for some (more) path separators. #27442

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 1, 2019

Conversation

drodriguez
Copy link
Contributor

Recently introduced tests have some of their path separators output with
Windows separators. Adapt the test to account for the different output
in Windows.

The original PR missed a couple of quoting, a path separator, and a double-escaped Windows path separator.

Recently introduced tests have some of their path separators output with
Windows separators. Adapt the test to account for the different output
in Windows.
@drodriguez drodriguez requested a review from compnerd September 30, 2019 20:03
@drodriguez
Copy link
Contributor Author

@swift-ci please test Windows platform

@drodriguez
Copy link
Contributor Author

@swift-ci please smoke test

Copy link
Member

@compnerd compnerd left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

sigh thanks

@drodriguez
Copy link
Contributor Author

Restarting after checking that CMake 3.15 is installed in the PR machine.

@swift-ci please test Windows platform

@drodriguez drodriguez merged commit 02e1d6e into swiftlang:master Oct 1, 2019
@drodriguez drodriguez deleted the windows-fix-test-paths branch October 1, 2019 00:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants