Skip to content

Update FloatingPointTypes.swift.gyb #27461

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 2, 2019
Merged

Conversation

own2pwn
Copy link
Contributor

@own2pwn own2pwn commented Oct 1, 2019

IMO the original message can be confusing because the Float80 type seems to be available only on MacOS.

You can reproduce this error by compiling source code that it and targets an iOS device.

Corrects intent that this type seems to be available only on MacOS targets.
@own2pwn
Copy link
Contributor Author

own2pwn commented Oct 2, 2019

@swift-ci please smoke

@stephentyrone
Copy link
Contributor

@swift-ci please smoke test and merge

@own2pwn
Copy link
Contributor Author

own2pwn commented Oct 2, 2019

@stephentyrone hey Stephen, what do you think if error message would be more concrete about platform? e.g. Float80 is available only on MacOS.

@stephentyrone
Copy link
Contributor

@stephentyrone hey Stephen, what do you think if error message would be more concrete about platform? e.g. Float80 is available only on MacOS.

That would be a lie, since it's also available on Linux / x86_64, right? I don't think trying to precisely define where it's available is especially useful in this error message; what matters is that it isn't available for the current platform, whatever that is.

@stephentyrone
Copy link
Contributor

I.e. I like the solution in this PR.

@stephentyrone
Copy link
Contributor

In case it's not obvious, the Linux build failure is unrelated to this change. I'll re-run the test once it's sorted out.

@stephentyrone
Copy link
Contributor

@swift-ci please smoke test linux

@stephentyrone stephentyrone merged commit 3ec5e76 into swiftlang:master Oct 2, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants