[windows] Adapt Windows build script to latest changes. #27475
Conversation
|
@swift-ci please test Windows platform |
|
I log into the machine and it seemed to not have applied the patch when testing. I have cleaned the build directory to try to get a clean start. I will keep an eye while the next run happens. @swift-ci please test Windows platform |
drodriguez
force-pushed
the
batch-script-lldb-fixes
branch
from
c203f8a to
9a768d1
Compare
|
Don't go breaking my lines 🎶 @swift-ci please test Windows platform |
|
@swift-ci please test Windows platform |
|
@swift-ci please smoke test |
1 similar comment
|
@swift-ci please smoke test |
|
Modified CI machines Python installation to match the expected installation from Visual Studio. @swift-ci please test Windows platform |
|
I don't think the failing macOS LLDB is related. Retrying just in case it is flaky. @swift-ci please smoke test macOS platform |
|
Retrying after modifying the installation again. @swift-ci please test Windows platform |
drodriguez
force-pushed
the
batch-script-lldb-fixes
branch
from
9a768d1 to
aa8a41d
Compare
|
Removed the docs that were modified in another PR. @swift-ci please test Windows platform |
|
@swift-ci please smoke test |
|
@swift-ci please test Windows platform |
LLDB in Windows was failing to build in the community CI. From comparing the invocation of build-script-impl and windows-build.bat it seems that we have migrated from LLDB_PATH_TO_*_SOURCE/BUILD variables to *_DIR variables. Additionally I needed to disable building the test on Windows because the community CI doesn't build LLD, which seems to be needed for the tests. I don't understand exactly why before the test were being skipped automatically. Also, a lot of CMake variables have been annotated with their expected types. At least the new *_DIR variables were being interpreted as strings in one occassion and the path separators were making CMake fail. The other case was a boolean that must have been interpreted as a string.
drodriguez
force-pushed
the
batch-script-lldb-fixes
branch
from
aa8a41d to
7c1c58e
Compare
|
@swift-ci please test Windows platform |
|
@swift-ci please smoke test |
|
@compnerd: it wasn't reported back here, but https://ci-external.swift.org/view/Pull%20Request/job/swift-PR-windows/122/ failed during the tests of Swift. LLDB was built (which was the main blockage). We can either merge as is, or wait for the tests to be fixed. I will try to start looking at them, but feel free to merge if you think is better (IMO fixing the tests in different PRs might be). |
|
See #27510 for a fix of some of the tests, and a summary of others that failed in this PR. |
LLDB in Windows was failing to build in the community CI. From comparing
the invocation of build-script-impl and windows-build.bat it seems that
we have migrated from LLDB_PATH_TO_*_SOURCE/BUILD variables to *_DIR
variables.
Additionally I needed to disable building the test on Windows because
the community CI doesn't build LLD, which seems to be needed for the
tests. I don't understand exactly why before the test were being skipped
automatically.
Also, a lot of CMake variables have been annotated with their expected
types. At least the new *_DIR variables were being interpreted as
strings in one occassion and the path separators were making CMake fail.
The other case was a boolean that must have been interpreted as a
string.
@compnerd: You might need to make some of these changes in the Azure CI configuration too, but I leave that to your decision. I also took the liberty to modify the documentation a little.