AST: remove dump for GSB
#27494
Merged
AST: remove dump for GSB
#27494
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
CC: @DougGregor |
|
@swift-ci please test |
|
Since dump() is only meant to be called from a debugger, can you leave it in? Or fix the UB? |
|
@slavapestov, I did leave it in, just behind the macro since it will not even build. The UB is the entire graph writing support, that needs to be completely rewritten I think. The template specialization of |
DougGregor
requested changes
Oct 2, 2019
This relied on UB as per [meta.rqmts]p4 (http://eel.is/c++draft/meta#rqmts-4) and has been UB since C++11 20.9.2p1 has the same restriction. MSVC 19.24 became more stringent and silently ignores this now, preventing the Swift build. Require the user to explicitly pass in `-DSWIFT_PERMIT_UNDEFINED_BEHAVIOR` to get the dump functionality.
|
@swift-ci please test |
|
Build failed |
|
Build failed |
DougGregor
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This relied on UB as per [meta.rqmts]p4
(http://eel.is/c++draft/meta#rqmts-4) and has been UB since C++11
20.9.2p1 has the same restriction.
MSVC 19.24 became more stringent and silently ignores this now,
preventing the Swift build. Require the user to explicitly pass in
-DSWIFT_PERMIT_UNDEFINED_BEHAVIORto get the dump functionality.Replace this paragraph with a description of your changes and rationale. Provide links to external references/discussions if appropriate.
Resolves SR-NNNN.