Skip to content

More idiomatic use of llvm::hash_combine in many places #27497

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Oct 4, 2019

Conversation

jrose-apple
Copy link
Contributor

  • No need to hash input values first
  • Pass many values to a single hash_combine to save on intermediates
  • Use hash_combine_range instead of a loop of hash_combines

No functionality change.

@jrose-apple
Copy link
Contributor Author

I'll rebase this on top of #27469 once that goes in.

- No need to hash input values first
- Pass many values to a single hash_combine to save on intermediates
- Use hash_combine_range instead of a loop of hash_combines

No functionality change.
@jrose-apple jrose-apple force-pushed the se-0206-but-for-llvm branch from 4701b64 to 188c14c Compare October 3, 2019 16:19
@jrose-apple
Copy link
Contributor Author

@swift-ci Please smoke test

Copy link
Contributor

@CodaFi CodaFi left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jrose-apple jrose-apple merged commit b32e82c into swiftlang:master Oct 4, 2019
@jrose-apple jrose-apple deleted the se-0206-but-for-llvm branch October 4, 2019 20:08
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants