[ownership] Allow for the ownership verifier to be run in non-asserts… #27499
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci smoke test |
… builds if -sil-verify-all is set. This is matching the behavior of the rest of the verifier. NOTE: Both early exit if said flag is not set, so this should not hit compile time in any way unless the flag is set (in which case someone is asking for more verification...). While I was here, I also noticed an ancillary bug where we were not checking if a value was from in a block that was in a SILGlobalVariable or a SILFunction. We already had a check that stopped this early when validating ownership of SILInstructions. I guess we have never had a situation where the verifier was given values to run on SILGlobalVariable blocks.
gottesmm
force-pushed
the
pr-dc6371871f1797246355f4fc6795f1d0116e360a
branch
from
923eff6 to
d535e3e
Compare
|
@swift-ci smoke test |
|
@swift-ci smoke test os x platform |
beccadax
approved these changes
Oct 2, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
… builds if -sil-verify-all is set.
This is matching the behavior of the rest of the verifier. NOTE: Both early exit
if said flag is not set, so this should not hit compile time in any way unless
the flag is set (in which case someone is asking for more verification...).
While I was here, I also noticed an ancillary bug where we were not checking if
a value was from in a block that was in a SILGlobalVariable or a SILFunction. We
already had a check that stopped this early when validating ownership of
SILInstructions. I guess we have never had a situation where the verifier was
given values to run on SILGlobalVariable blocks.