Fix the new Swift NSMutableArray subclass to match edge case behavior in two more cases #27504
+8
−2
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@swift-ci please smoke test |
|
These definitely need test cases, especially the situation where |
… in two more cases
Catfish-Man
force-pushed
the
hifi-masquerade
branch
from
c3f5665 to
3d321c1
Compare
|
@swift-ci please smoke test |
jrose-apple
reviewed
Oct 2, 2019
| contents = Array(buf) | ||
| } else { | ||
| // We make an Array here to make sure that something is holding onto the | ||
| // objects in `buf`, since replaceSubrange could release them |
There was a problem hiding this comment.
Oof. Optimize later to check, I guess?
There was a problem hiding this comment.
If it looks relevant in practice, sure
There was a problem hiding this comment.
You're performing an extra copy this way, at least formally.
There was a problem hiding this comment.
(which is the point, of course)
There was a problem hiding this comment.
Right, but that just brings us down to NSMutableArray's speed, in theory. Anything better here would be a win on top of that which (probably) makes it nice to have rather than necessary.
lorentey
approved these changes
Oct 3, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We now support swapping an index with itself, and replacing subranges with elements already in the array