Requestify whether a decl is an ABI compatible override #27524
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This commit adds `IsABICompatibleOverrideRequest`, which checks if the decl is an override, and if so whether it's ABI compatible with the base This is then usedto replace the logic for computing `isValidKeyPathComponent` in addition to being used in `requiresNewVTableEntry`.
|
@swift-ci please smoke test |
slavapestov
approved these changes
Oct 4, 2019
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds
IsABICompatibleOverrideRequest, which checks if the decl is an override, and if so whether it's ABI compatible with the base. This is then used to replace the logic for computingisValidKeyPathComponentin addition to being used inrequiresNewVTableEntry.I decided not to completely get rid of
isValidKeyPathComponentfor now, asrequiresNewVTableEntrydoes some additional checks which we don't want to consider (for example, whether the decl is final).